Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the test structure by moving the System Administrator creation from the global setup_session fixture to a local fixture that is only used by tests that specifically need to verify system directory protection. Additionally, it improves test execution by suppressing coverage warnings for auto-generated files.
Changes:
- Moved System Administrator creation from global setup to a test-specific fixture
- Removed System Administrator from expected test results in search and role tests
- Configured coverage to ignore auto-generated dishka factory files
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Removed System Administrator creation from global setup_session fixture and cleaned up unused imports |
| tests/test_api/test_main/test_router/conftest.py | Added add_system_administrator fixture for tests requiring system directory |
| tests/test_api/test_main/test_router/test_delete.py | Added add_system_administrator fixture dependency |
| tests/test_api/test_main/test_router/test_modify.py | Added add_system_administrator fixture dependency |
| tests/test_api/test_main/test_router/test_modify_dn.py | Added add_system_administrator fixture dependency |
| tests/search_request_datasets.py | Removed System Administrator from expected search results in test datasets |
| tests/test_api/test_main/test_router/test_search.py | Removed System Administrator from expected search results |
| tests/test_ldap/test_roles/test_search.py | Removed System Administrator from expected role search results |
| pyproject.toml | Added coverage omit pattern for dishka factory files |
| docker-compose.test.yml | Added CoverageWarning suppression to pytest command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
milov-dmitriy
force-pushed
the
refactor_merge_enterprise_tests
branch
from
c012848 to
e008445
Compare
milov-dmitriy
force-pushed
the
refactor_merge_enterprise_tests
branch
from
e008445 to
4c506eb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rimu-stack
approved these changes
Jan 16, 2026
Misha-Shvets
approved these changes
Jan 16, 2026
rimu-stack
added a commit
that referenced
this pull request
Jan 28, 2026
* Add: directory attributes value validations (#857) * Add: addRequest validate `new_name` (#862) * fix: update push branch from main to dev in build workflow (#866) * Http codes with map 774 (#836) * Added dishka container to migrations (#868) * Refactor: integrate NetworkPolicyGateway into LDAP session management (#863) * Add default admin name 1111 (#872) * Refactor syslog-ng configuration and enhance SyslogSender class (#871) * Refactor: git checks (#869) * Add: global LDAP server (#875) * Fix: global ldap server (#877) * Rework dependencies initialization in migrations (#880) * add: UDP port mapping for LDAP service in docker-compose.yml (#882) * Refactor ldap server (#867) * Add: clear user password history (#874) * Fix migration 275222846605 (#881) * Add KRBAPIConnectionError handling to error map in krb5_router.py (#885) * Add: directory is_system (#884) * add: handling KRBAPIConnectionError in KerberosService exceptions (#886) * Refactor: merge enterprise tests (#887) * add: enqueue param for loguru (#888) * Add: tmpfs and volume prune and kadmin_api depends on kdc (#891) * New CI (#890) * add: Contact entity type (#896) * refactor: rename services to System (#883) * Hotfix262 (#898) * Fix: user addRequest: recreate principal if exists already (#897) * Enhance AddRequest: suppress KRBAPIPrincipalNotFoundError during principal deletion (#902) * Refactor: cosmetic (#900) * Add: Global Catalog logger (#892) * Refactor: ModifyRequest (#893) * Fix: Correct path assignment in _update_descendants function (#904) * refactor: fix paths kadmin_api entrypoint (#903) * add: rename services (#905) * fix: replace services with system (#906) --------- Co-authored-by: Milov Dmitriy <[email protected]> Co-authored-by: Ruslan <[email protected]> Co-authored-by: Misha-Shvets <[email protected]> Co-authored-by: Михаил Михайлов <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Минорный рефакторинг для порядка:
Fix: